Skip to content

feat(core): Add eventToSentryRequest test for optional event properties #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2022
Merged

feat(core): Add eventToSentryRequest test for optional event properties #4396

merged 1 commit into from
Jan 13, 2022

Conversation

lobsterkatie
Copy link
Member

All properties in the Event interface are optional. This adds a test to make sure that eventToSentryRequest's success doesn't depend on any of them being there.

@lobsterkatie lobsterkatie mentioned this pull request Jan 13, 2022
Merged
@github-actions
Copy link
Contributor

size-limit report

Path Base Size (c1341fd) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.75 KB 19.75 KB +0.01% 🔺
@sentry/browser - CDN Bundle (minified) 62.86 KB 62.86 KB +0.01% 🔺
@sentry/browser - Webpack 22.29 KB 22.29 KB 0%
@sentry/browser - Webpack - gzip = false 76.11 KB 76.11 KB 0%
@sentry/react - Webpack 22.32 KB 22.32 KB 0%
@sentry/nextjs Client - Webpack 46.46 KB 46.46 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.41 KB 28.41 KB +0.02% 🔺

@lobsterkatie lobsterkatie merged commit c5127a0 into master Jan 13, 2022
@lobsterkatie lobsterkatie deleted the kmclb-add-optional-field-event-processing-test branch January 13, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lobsterkatie @iker-barriocanal